Forum posts to 'Extending and hacking'

Re: temp fix for if Odd bug

Tue, 13 May 2008 15:27:23 +1200

i just uploaded to open.silverstripe.com - i added the file to the original trouble ticket. not sure if that's the right way to do it.

Posted to: temp fix for if Odd bug

Re: temp fix for if Odd bug

Sam Minnee — Tue, 13 May 2008 14:35:57 +1200

That fix looks good; can you post it to open.silverstripe.com so that we can integrate it with the core? :-)

Posted to: temp fix for if Odd bug

temp fix for if Odd bug

Tue, 13 May 2008 13:21:52 +1200

i noticed there was a 3-month old, [url=http://open.silverstripe.com/ticket/2243]low priority ticket[/url] for the [b]if Odd[/b] failing. i came up with what is probably a dirty hack, but basically i changed:

line 647 in VariableData.php from

[code]
function Odd() {
return !$this->iteratorPos % 2;
}
[/code]

to

[code]
function Odd() {
return !$this->Even();
}
[/code]

it seems to work, and so far hasn't caused any weird spikes in performance. hope this helps those of you in need of a quick fix, until someone who knows PHP can fix it properly.

Posted to: temp fix for if Odd bug